8000 chore: bump ehttpc -> 0.4.8 by thalesmg · Pull Request #10548 · emqx/emqx · GitHub
[go: up one dir, main page]
Skip to content

chore: bump ehttpc -> 0.4.8 #10548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2023
Merged

chore: bump ehttpc -> 0.4.8 #10548

merged 1 commit into from
Apr 27, 2023

Conversation

@thalesmg
Copy link
Contributor
@thalesmg thalesmg commented Apr 27, 2023 •
edited
Loading

Targeting release-50

Fixes https://emqx.atlassian.net/browse/EMQX-9656

See also emqx/ehttpc#45

This fixes a race condition where the remote server would close the connection before or during requests, and, depending on timing, an {error, normal} response would be returned. In those cases, we should just retry the request without using up "retry credits".

Summary

🤖 Generated by Copilot at 207f081

This pull request fixes a race condition in the HTTP client library ehttpc that could cause EMQ X to crash. It updates the ehttpc dependency in mix.exs and adds a changelog entry in changes/ce/fix-10548.en.md.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@thalesmg thalesmg force-pushed the bump-ehttpc-048-v50 branch from e1d402d to 207f081 Compare April 27, 2023 12:29
@thalesmg
chore: bump ehttpc -> 0.4.8
77f5e46 
Fixes https://emqx.atlassian.net/browse/EMQX-9656

See also emqx/ehttpc#45

This fixes a race condition where the remote server would close the
connection before or during requests, and, depending on timing, an
`{error, normal}` response would be returned.  In those cases, we
should just retry the request without using up "retry credits".
@thalesmg thalesmg force-pushed the bump-ehttpc-048-v50 branch from 207f081 to 77f5e46 Compare April 27, 2023 17:10
@thalesmg thalesmg changed the base branch from master to release-50 April 27, 2023 17:10
@thalesmg thalesmg closed this Apr 27, 2023
@thalesmg thalesmg reopened this Apr 27, 2023
@thalesmg thalesmg marked this pull request as ready for review April 27, 2023 18:41
@thalesmg thalesmg requested a review from a team as a code owner April 27, 2023 18:41
@thalesmg thalesmg merged commit d7c4585 into emqx:release-50 Apr 27, 2023
801F @thalesmg thalesmg deleted the bump-ehttpc-048-v50 branch April 27, 2023 20:30
@yanzhiemq yanzhiemq mentioned this pull request May 6, 2023
Merged
@p-linnane p-linnane mentioned this pull request May 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ieQu1 ieQu1 ieQu1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thalesmg @ieQu1
0