8000 fix: inval listener option cause segfault by qzhuyan · Pull Request #10078 · emqx/emqx · GitHub
[go: up one dir, main page]
Skip to content

fix: inval listener option cause segfault #10078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 7, 2023
Merged

fix: inval listener option cause segfault #10078

merged 3 commits into from
Mar 7, 2023

Conversation

@qzhuyan
Copy link
Contributor
@qzhuyan qzhuyan commented Mar 6, 2023 •
edited
Loading

Targeting release-50

Fixes EMQX-9100

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md and .zh.md files
  • For internal contributor: there is a jira ticket to track this change
    If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
    Schema changes are backward compatible

@qzhuyan qzhuyan mentioned this pull request Mar 6, 2023
Merged
6 tasks
@coveralls
Copy link
Collaborator
coveralls commented Mar 6, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4345100106

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 24 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.01%) to 80.84%
Files with Coverage Reduction New Missed Lines %
apps/emqx_authn/src/enhanced_authn/emqx_enhanced_authn_scram_mnesia.erl 1 85.07%
apps/emqx_gateway/src/mqttsn/emqx_sn_channel.erl 1 73.04%
apps/emqx/src/emqx_cm.erl 1 91.28%
apps/emqx/src/emqx_logger.erl 1 80.49%
apps/emqx/src/emqx_session.erl 1 87.6%
apps/emqx/src/emqx_broker.erl 2 85.96%
apps/emqx/src/emqx_channel.erl 3 87.11%
apps/emqx/src/emqx_sys_mon.erl 5 86.46%
apps/emqx/src/emqx_reason_codes.erl 9 89.71%
Totals Coverage Status
Change from base Build 4324287322: 0.01%
Covered Lines: 24075
Relevant Lines: 29781
💛 - Coveralls

@qzhuyan qzhuyan force-pushed the fix/william/inval-listener-options-segfault branch from d2de7c9 to c283902 Compare March 6, 2023 15:29
@qzhuyan qzhuyan marked this pull request as ready for review March 7, 2023 08:11
@qzhuyan qzhuyan requested review from a team and lafirest as code owners March 7, 2023 08:11
@qzhuyan qzhuyan merged commit 422f8e3 into emqx:release-50 Mar 7, 2023
@Porkepix Porkepix mentioned this pull request Mar 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@id id id approved these changes

@lafirest lafirest lafirest approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@qzhuyan @coveralls @id @lafirest
0