8000 Add pre-commit hooks by yakutovicha · Pull Request #132 · empa-scientific-it/python-tutorial · GitHub
[go: up one dir, main page]
Skip to content

Add pre-commit hooks #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 13, 2023
Merged

Add pre-commit hooks #132

merged 5 commits into from
Jul 13, 2023

Conversation

yakutovicha
Copy link
Member

fixes #24

< 8000 circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" fill="none" />

@yakutovicha yakutovicha marked this pull request as draft July 12, 2023 13:00
@edoardob90
Copy link
Member

Shouldn't pre-commit be added as a "dev" dependency somewhere?

@yakutovicha
Copy link
Member Author

Shouldn't pre-commit be added as a "dev" dependency somewhere?

At the moment I would add it to environment.yml.

If we want to make it a dev dependency, we should convert this repo into a proper Python package.

@yakutovicha yakutovicha requested a review from edoardob90 July 12, 2023 14:22
@yakutovicha yakutovicha marked this pull request as ready for review July 12, 2023 14:22
@yakutovicha
Copy link
Member Author

Admittedly, I didn't fix all the issues reported by pre-commit. But slowly we will get there 👍

edoardob90
edoardob90 requested changes Jul 13, 2023
View reviewed changes
Copy link
Member
@edoardob90 edoardob90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might be a few other warnings to add to the ignore list, but I guess this is a good starting point 👍🏻

@yakutovicha @edoardob90
Update .pre-commit-config.yaml
8d1ff09 
Co-authored-by: Edoardo Baldi <edoardo.baldi@empa.ch>
@yakutovicha yakutovicha requested a review from edoardob90 July 13, 2023 14:51
@yakutovicha yakutovicha merged commit 5da0ace into main Jul 13, 2023
@yakutovicha yakutovicha deleted the chore/add-pre-commit-hooks branch July 13, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edoardob90 edoardob90 edoardob90 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add pre-commit hooks

2 participants

@yakutovicha @edoardob90
0