8000 Fix tests to I/O exercises by yakutovicha · Pull Request #108 · empa-scientific-it/python-tutorial · GitHub
[go: up one dir, main page]
Skip to content

Fix tests to I/O exercises #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 4, 2023
Merged

Fix tests to I/O exercises #108

merged 6 commits into from
May 4, 2023

Conversation

yakutovicha
Copy link
Member
@yakutovicha yakutovicha commented May 4, 2023 •
edited
Loading

fixes #109

@yakutovicha yakutovicha requested review from baffelli and edoardob90 and removed request for edoardob90 May 4, 2023 07:58
edoardob90
edoardob90 reviewed May 4, 2023
View reviewed changes
@edoardob90 edoardob90 changed the title Fix solution for the find_all_files exercise. Fix tests to I/O exercises May 4, 2023
edoardob90
edoardob90 requested changes May 4, 2023
View reviewed changes
Copy link
Member
@edoardob90 edoardob90 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also test_print_salutation doesn't work. contextlib does not have a redirect_stdin method. I'm not sure how we want to test that exercise.

@yakutovicha
Copy link
Member Author

Also test_print_salutation doesn't work. contextlib does not have a redirect_stdin method. I'm not sure how we want to test that exercise.

This one is not supposed to be auto-tested. @baffelli wrote it in the description.

@edoardob90
Copy link
Member

Also test_print_salutation doesn't work. contextlib does not have a redirect_stdin method. I'm not sure how we want to test that exercise.

This one is not supposed to be auto-tested. @baffelli wrote it in the description.

Then let's remove the test, because it's not working and not needed

@yakutovicha
Copy link
Member Author

Also test_print_salutation doesn't work. contextlib does not have a redirect_stdin method. I'm not sure how we want to test that exercise.

This one is not supposed to be auto-tested. @baffelli wrote it in the description.

Then let's remove the test, because it's not working and not needed

I let @baffelli comment on this.

@edoardob90 edoardob90 self-requested a review May 4, 2023 09:27
@baffelli
Copy link
Member
baffelli commented May 4, 2023

Also test_print_salutation doesn't work. contextlib does not have a redirect_stdin method. I'm not sure how we want to test that exercise.

This one is not supposed to be auto-tested. @baffelli wrote it in the description.

Then let's remove the test, because it's not working and not needed

I let @baffelli comment on this.

Indeed we can remove it. redirect_stdin was a silly suggestion from copilot. Anyway I could not find an elegant way to capture stdin, therefore we can safely remove the test.

baffelli added 2 commits May 4, 2023 19:25
@baffelli
Update test_input_output.py
0268ff1 
Removed unused print
@baffelli
Update test_input_output.py
838d7a8 
Improved line stripping.
edoardob90
edoardob90 approved these changes May 4, 2023
View reviewed changes
Copy link
Member
@edoardob90 edoardob90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good 🚀

@edoardob90 edoardob90 merged commit af22df4 into main May 4, 2023
@edoardob90 edoardob90 deleted the fix/solution-find-all-files branch May 4, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edoardob90 edoardob90 edoardob90 approved these changes

@baffelli baffelli baffelli approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

I/O: fix test to solution_read_write_file

3 participants

@yakutovicha @edoardob90 @baffelli
0