Remove potential quotes around If-Match value #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
reviewed
Nov 2, 2022
864e543 to
8828929
Compare
emersion
reviewed
Nov 15, 2022
emersion
reviewed
Nov 15, 2022
8828929 to
4de76a4
Compare
emersion
reviewed
Nov 22, 2022
emersion
reviewed
Nov 22, 2022
|
Other than that nitpick, LGTM! |
The `If-Match` and `If-None-Match` conditional headers can have either a wildcard or a (quoted) ETag as value. However, the ETag _could_ be a literal `*`, so care must be taken to allow these cases to be distinguished. The values of these headers have to be handled by the backend, so export a type that facilitates working with these values.
4de76a4 to
9db3597
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to t
2F41
he code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the If-Match header is an ETag, the ETag is quoted. Remove the quotes so that the application does not have to deal with this.
Also, add a comment that If-None-Match can potentially be an ETag. This does not seem to be commonly used, though.