8000 Align WebSocket.Frame.encode/2 spec with WebSocket.encode/2 by ColaCheng · Pull Request #29 · elixir-mint/mint_web_socket · GitHub
[go: up one dir, main page]
Skip to content

Align WebSocket.Frame.encode/2 spec with WebSocket.encode/2#29

Merged
the-mikedavis merged 1 commit intoelixir-mint:mainfrom
ColaCheng:fix_encode_spec
Dec 11, 2022
Merged

Align WebSocket.Frame.encode/2 spec with WebSocket.encode/2#29
the-mikedavis merged 1 commit intoelixir-mint:mainfrom
ColaCheng:fix_encode_spec

Conversation

@ColaCheng
Copy link
Contributor
@ColaCheng ColaCheng commented Dec 10, 2022

The Mint.WebSocket.shorthand_frame() is missing in the Mint.WebSocket.Frame.encode/2 spec.

@coveralls
Copy link
coveralls commented Dec 10, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 87284007604f07b7ccb8cd7ac0c85bfe38fe143a-PR-29

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 89.459%
Totals Coverage Status
Change from base Build d17898b3b37c980e33e9f428b07698312a8cbc85: 0.3%
Covered Lines: 314
Relevant Lines: 351
💛 - Coveralls

the-mikedavis
the-mikedavis approved these changes Dec 11, 2022
View reviewed changes
Copy link
Collaborator
@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good catch, thank you!

@the-mikedavis the-mikedavis changed the title Align WebSocket.Frame.encode/2 spec with WebSocket.encode/2. Align WebSocket.Frame.encode/2 spec with WebSocket.encode/2 Dec 11, 2022
@the-mikedavis the-mikedavis merged commit ab1f6fe into elixir-mint:main Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ColaCheng @coveralls @the-mikedavis
0