FFFF Add Dialyxir and fix all warnings by rkallos · Pull Request #27 · elixir-mint/mint_web_socket · GitHub
[go: up one dir, main page]
Skip to content

Add Dialyxir and fix all warnings#27

Merged
the-mikedavis merged 15 commits intoelixir-mint:mainfrom
rkallos:add-dialyxir
Dec 9, 2022
Merged

Add Dialyxir and fix all warnings#27
the-mikedavis merged 15 commits intoelixir-mint:mainfrom
rkallos:add-dialyxir

Conversation

@rkallos
Copy link
Contributor
@rkallos rkallos commented Nov 30, 2022

Thank you very much for Mint.WebSocket!

This PR adds :dialyxir to the project and runs it in CI.

When I added :dialyxir to this project, I saw there were warnings, so I fixed them in the best way(s) I knew how. I also cleaned some things up where I saw the opportunity to, such as in TestServer.

@coveralls
Copy link
coveralls commented Nov 30, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 6d394f37eac7c2ce759e5f26480af700f023a93f-PR-27

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 14 of 16 (87.5%) changed or added relevant lines in 3 files are covered.
  • 13 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 89.174%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/mint/web_socket.ex 6 7 85.71%
lib/mint/web_socket/frame.ex 3 4 75.0%
Files with Coverage Reduction New Missed Lines %
lib/mint/web_socket/frame.ex 13 87.16%
Totals Coverage Status
Change from base Build 4fbd3f5caf48d71875b2596b57eac80fa12b327b: 0.2%
Covered Lines: 313
Relevant Lines: 351
💛 - Coveralls

the-mikedavis
the-mikedavis reviewed Dec 3, 2022
View reviewed changes
Copy link
Collaborator
@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, this is looking good! 😀

I left some minor comments

the-mikedavis
the-mikedavis reviewed Dec 5, 2022
View reviewed changes
@the-mikedavis the-mikedavis merged commit e76205e into elixir-mint:main Dec 9, 2022
@the-mikedavis
Copy link
Collaborator
the-mikedavis commented Dec 9, 2022

Thank you!

@the-mikedavis the-mikedavis mentioned this pull request Dec 9, 2022
Closed
@mruoss mruoss mentioned this pull request Dec 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rkallos @coveralls @the-mikedavis
0