8000 Store frames to guest as Map by kevinsawicki · Pull Request #9287 · electron/electron · GitHub
[go: up one dir, main page]
Skip to content

Store frames to guest as Map #9287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 26, 2017
Merged

Store frames to guest as Map #9287

merged 2 commits into from
Apr 26, 2017

Conversation

kevinsawicki
Copy link
Contributor

Using an object for this mapping causes errors to be thrown if the frame name matched a built-in object property (like __proto__). Now it uses a Map which supports all frame names.

@kevinsawicki kevinsawicki changed the title Store frames to guest as map Store frames to guest as Map Apr 25, 2017
@YurySolovyov
Copy link
Contributor

Spotted any other places for this kind of cleanup?

@kevinsawicki
Copy link
Contributor Author

Spotted any other places for this kind of cleanup?

Haven't seen any other obvious ones, most other object maps use generated ids that are incrementing numbers.

@kevinsawicki kevinsawicki force-pushed the store-frames-to-guest-as-map branch from 1819b6f to 91a1e5c Compare April 26, 2017 17:14
@kevinsawicki kevinsawicki merged commit 0aa53f4 into master Apr 26, 2017
@kevinsawicki kevinsawicki deleted the store-frames-to-guest-as-map branch April 26, 2017 17:47
@github-actions github-actions bot mentioned this pull request Dec 19, 2022
Merged
@github-actions github-actions bot mentioned this pull request Jan 31, 2023
Open
This was referenced Feb 14, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinsawicki @YurySolovyov
0