E52E fix: default accelerator for role-based menu items by codebytere · Pull Request #49558 · electron/electron · GitHub
[go: up one dir, main page]
Skip to content

fix: default accelerator for role-based menu items #49558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
codebytere wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: default accele FF8 rator for role-based menu items #49558

codebytere wants to merge 1 commit into from
+63 −4

Conversation

@codebytere
Copy link
Member
@codebytere codebytere commented Jan 28, 2026 •
edited
Loading

Description of Change

Closes #48313.

Role-based menu items (copy, paste, cut, etc.) were returning null for their accelerator property, even though these roles have default keyboard shortcuts defined in menu-item-roles.ts.

To fix this, pass roles.getDefaultAccelerator(this.role) as the default value to overrideReadOnlyProperty('accelerator') so that role-based items correctly expose their expected accelerators.

Also fixes an incorrect type in menu-item.md.

Checklist

Release Notes

Notes: Fixed an issue where role-based menu items were incorrectly returning null for their accelerator property.

@codebytere @Kimgun3383
fix: apply default accelerator for role-based menu items
eda57ba 
Co-authored-by: Kimgun3383 <tygob5247@gmail.com>
@codebytere codebytere added semver/patch backwards-compatible bug fixes target/39-x-y 9E84 PR should also be added to the "39-x-y" branch. target/40-x-y PR should also be added to the "40-x-y" branch. target/41-x-y PR should also be added to the "41-x-y" branch. labels Jan 28, 2026
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jan 28, 2026
@codebytere codebytere changed the title fix: apply default accelerator for role-based menu items fix: default accelerator for role-based menu items Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ckerr ckerr Awaiting requested review from ckerr

@VerteDinde VerteDinde Awaiting requested review from VerteDinde

@dsanders11 dsanders11 Awaiting requested review from dsanders11

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

new-pr 🌱 PR opened recently semver/patch backwards-compatible bug fixes target/39-x-y PR should also be added to the "39-x-y" branch. target/40-x-y PR should also be added to the "40-x-y" branch. target/41-x-y PR should also be added to the "41-x-y" branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Accelerator null on predefined menu roles

2 participants

@codebytere
0