8000 ci: rework reapply patches by dsanders11 · Pull Request #49552 · electron/electron · GitHub
[go: up one dir, main page]
Skip to content

ci: rework reapply patches #49552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dsanders11 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci: rework reapply patches #49552

dsanders11 wants to merge 1 commit into from
+84 −49

Conversation

@dsanders11
Copy link
Member
@dsanders11 dsanders11 commented Jan 28, 2026

Description of Change

#49516 didn't survive first contact, due to some flawed assumptions. gh run rerun will fail if the job/workflow is already running, and you can't cancel an individual job, only a full workflow. That means the previous approach of having apply-patches as a job inside the build.yml workflow isn't workable because there's no way to cancel and re-run just that job without canceling the whole workflow, and we want to avoid re-running the full build.

This PR reworks the approach to put apply-patches in a new workflow that runs against PRs that touch patches or DEPS, and updates rerun-apply-patches.yml to cancel the workflow if it's in-progress, wait for it to finish canceling, and then rerun the whole workflow.

Checklist

  • PR description included

Release Notes

Notes: none

@dsanders11 dsanders11 added semver/none target/38-x-y PR should also be added to the "38-x-y" branch. target/39-x-y PR should also be added to the "39-x-y" branch. target/40-x-y PR should also be added to the "40-x-y" branch. target/41-x-y PR should also be added to the "41-x-y" branch. labels Jan 28, 2026
@dsanders11 dsanders11 force-pushed the ci/rework-apply-patches-job branch 3 times, most recently from fb4d119 to 0762bea Compare January 28, 2026 07:20
@dsanders11 dsanders11 force-pushed the ci/rework-apply-patches-job branch from 0762bea to 739e579 Compare January 28, 2026 07:26
@dsanders11 dsanders11 requested a review from jkleinsc January 29, 2026 00:54
@dsanders11 dsanders11 marked this pull request as ready for review January 29, 2026 00:54
@dsanders11 dsanders11 requested a review from a team as a code owner January 29, 2026 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkleinsc jkleinsc Awaiting requested review from jkleinsc

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

semver/none target/38-x-y PR should also be added to the "38-x-y" branch. target/39-x-y PR should also be added to the "39-x-y" branch. target/40-x-y PR should also be added to the "40-x-y" branch. target/41-x-y PR should also be added to the "41-x-y" branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dsanders11
0