fix: prevent crash when GPU context unavailable in sharedTexture #49518
+130
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
reviewed
Jan 24, 2026
Member
There was a problem hiding this comment.
I don't think we need to log on every line here.
reitowo
suggested changes
Jan 25, 2026
Comment on lines
92
to
119
| if (!factory) { | ||
| LOG(ERROR) << "ImageTransportFactory is null"; | ||
| return nullptr; | ||
| } | ||
|
|
||
| auto* context_factory = factory->GetContextFactory(); | ||
| if (!context_factory) { | ||
| LOG(ERROR) << "ContextFactory is null"; | ||
| return nullptr; | ||
| } | ||
|
|
||
| scoped_refptr<viz::RasterContextProvider> provider = | ||
| context_factory->SharedMainThreadRasterContextProvider(); | ||
| if (!provider) { | ||
| LOG(ERROR) << "RasterContextProvider is null"; | ||
| return nullptr; | ||
| } | ||
|
|
||
| return provider->SharedImageInterface(); | ||
| } else { | ||
| return blink::SharedGpuContext::SharedImageInterfaceProvider() | ||
| ->SharedImageInterface(); | ||
| auto* provider = blink::SharedGpuContext::SharedImageInterfaceProvider(); | ||
| if (!provider) { | ||
| LOG(ERROR) | ||
| << "SharedImageInterfaceProvider is null, GPU context unavailable"; | ||
| return nullptr; | ||
| } | ||
|
|
||
| F440 | return provider->SharedImageInterface(); |
|
|
||
| std::string GetBase64StringFromSyncToken(gpu::SyncToken& sync_token) { | ||
| if (!sync_token.verified_flush()) { | ||
| auto* sii = GetSharedImageInterface(); |
Member
There was a problem hiding this comment.
I think instead of logging and silently return, is it possible to pass sii and context support as parameter in, instead of GetShareImageInterface, GetContextSupport in place? Then we can do checks earlier in outer entry functions with throwable javascript error.
| // Texture id for printing warnings like GC check. | ||
| std::string id; | ||
|
|
||
Member
There was a problem hiding this comment.
nit: remove spaces (You might want to run npm run lint to find lint errors locally before failing the CI)
Comment on lines
366
to
371
| if (!sii) { | ||
| LOG(WARNING) | ||
| << "Cannot update release sync token, SharedImageInterface is null"; | ||
| return; | ||
| } | ||
|
|
| base::AutoLock locker(release_sync_token_lock_); | ||
|
|
||
| auto* sii = GetSharedImageInterface(); | ||
| if (!sii) { |
| if (release_callback) { | ||
| GetContextSupport()->SignalSyncToken(release_sync_token, | ||
| std::move(release_callback)); | ||
| auto* context_support = GetContextSupport(); |
Member
|
Thanks for fixing this! |
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
codebytere
reviewed
Jan 26, 2026
Comment on lines
81
to
99
| if (!factory) { | ||
| LOG(ERROR) << "ImageTransportFactory is null"; | ||
| return nullptr; | ||
| } | ||
|
|
||
| auto* context_factory = factory->GetContextFactory(); | ||
| if (!context_factory) { | ||
| LOG(ERROR) << "ContextFactory is null"; | ||
| return nullptr; | ||
| } | ||
|
|
||
| scoped_refptr<viz::RasterContextProvider> provider = | ||
| context_factory->SharedMainThreadRasterContextProvider(); | ||
| if (!provider) { | ||
| LOG(ERROR) << "RasterContextProvider is null"; | ||
| return nullptr; | ||
| } | ||
|
|
||
| return provider->SharedImageInterface(); |
Member
There was a problem hiding this comment.
Same logging comments here as above
95b0bff to
8f73cfd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR fixes a critical crash in the
sharedTexture(introduced in #47317) module related to improper lifecycle management of the graphics context provider.The crash happens in the
ImportedSharedTexturedestructor when it callsSetupReleaseSyncTokenCallback(), which in turn callsGetContextSupport(). In renderer processes,GetContextSupport()attempts to dereference aWeakPtr<blink::WebGraphicsContext3DProviderWrapper>without first checking if the pointer is valid. When the GPU context is unavailable (e.g., during shutdown or GPU device loss), thisWeakPtris null, causing a CHECK failure.The fix introduces a safety check in
GetContextSupport()to verify the availability of the context provider before usage. Additionally, the destruction sequence has been updated to handle context loss gracefully, preventing theEXCEPTION_BREAKPOINTtriggered bybase::WeakPtr's internal checks.Stack Trace Included:
1
2
Checklist
npm testpassesRelease Notes
Notes: Fixed crash in sharedTexture module when GPU context becomes unavailable.