E513 fix: issues with xdg activation on Linux by codebytere · Pull Request #49499 · electron/electron · GitHub
[go: up one dir, main page]
Skip to content

fix: issues with xdg activation on Linux #49499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
codebytere wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: issues with xdg activation on Linux #49499

codebytere wants to merge 1 commit into fr 8000 om

Conversation

@codebytere
Copy link
Member
@codebytere codebytere commented Jan 23, 2026 •
edited
Loading

Description of Change

Refs CL:147736
Refs CL:7122102
Refs CL:6931376

Fixes an issue where XDG Activation doesn't work when window is already open. See this comment for further explanation

From CL:

FileManager1 API was preferred over OpenURI portal when showing items in
file manager (e.g. for Downloads page) due to files not being selected
in older versions of the portal as per crrev.com/c/3009959. In at least version 3 of the portal it seems the file selection works fine in gnome, and in version 4 there is support for setting the activation token in order to bring the file manager to the foreground. The FileManager1 API does not have an activation token parameter. So change the preference to use the portal always and also set the activation token there.

Checklist

Release Notes

Notes: Fixed an issue where some shell functionality may not work on Linux if the target window is already open.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/39-x-y PR should also be added to the "39-x-y" branch. target/40-x-y PR should also be added to the "40-x-y" branch. target/41-x-y PR should also be added to the "41-x-y" branch. labels Jan 23, 2026
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jan 23, 2026
@codebytere codebytere force-pushed the fix-xdg-activation-issue branch from 05dc853 to 433fc31 Compare January 23, 2026 11:35
@codebytere codebytere force-pushed the fix-xdg-activation-issue branch from 433fc31 to b60beb5 Compare January 23, 2026 11:45
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jan 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ckerr ckerr Awaiting requested review from ckerr

@jkleinsc jkleinsc Awaiting requested review from jkleinsc

@deepak1556 deepak1556 Awaiting requested review from deepak1556

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

semver/patch backwards-compatible bug fixes target/39-x-y PR should also be added to the "39-x-y" branch. target/40-x-y PR should also be added to the "40-x-y" branch. target/41-x-y PR should also be added to the "41-x-y" branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@codebytere
0