8000 build: remove deps_add_v8_object_setinternalfieldfornodecore.patch by trop[bot] · Pull Request #46998 · electron/electron · GitHub
[go: up one dir, main page]

Skip to content

build: remove deps_add_v8_object_setinternalfieldfornodecore.patch#46998

Merged
ckerr merged 1 commit into37-x-yfrom
trop/37-x-y-bp-build-remove-deps_add_v8_object_setinternalfieldfornodecore-patch-1746690011171
May 8, 2025
Merged

build: remove deps_add_v8_object_setinternalfieldfornodecore.patch#46998
ckerr merged 1 commit into37-x-yfrom
trop/37-x-y-bp-build-remove-deps_add_v8_object_setinternalfieldfornodecore-patch-1746690011171

Conversation

@trop
Copy link
Contributor
@trop trop bot commented May 8, 2025

Backport of #46992

See that PR for details.

Notes: none.

This was a Node 20-specific workaround that's no longer needed in Node 22.

Xref: nodejs/node#49874.

Co-authored-by: Charles Kerr <charles@charleskerr.com>
@trop trop bot requested a review from a team as a code owner May 8, 2025 07:40
@trop trop bot requested review from a team and ckerr May 8, 2025 07:40
@trop trop bot added 37-x-y backport This is a backport PR semver/none labels May 8, 2025
@ckerr ckerr merged commit 4eea6e4 into 37-x-y May 8, 2025
61 checks passed
@ckerr ckerr deleted the trop/37-x-y-bp-build-remove-deps_add_v8_object_setinternalfieldfornodecore-patch-1746690011171 branch May 8, 2025 20:34
@release-clerk
Copy link
release-clerk bot commented May 8, 2025

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0