fix: ensure tray icon is the proper size on linux #21904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
approved these changes
Jan 27, 2020
zcbenz
reviewed
Jan 28, 2020
zcbenz
approved these changes
Jan 28, 2020
deepak1556
approved these changes
Jan 28, 2020
jkleinsc
approved these changes
Jan 28, 2020
Member
|
Merging as WOA CI failures unrelated to PR changes. |
|
Release Notes Persisted
|
Contributor
|
I have automatically backported this PR to "8-x-y", please check out #21936 |
2 tasks
3 tasks
|
@ckerr This breaks icon size on Linux, Electron icons are tiny compared to other icons, locked to 22px. It looks hideous (all my other icons are fine) and if I use numbers in corner, they are unreadable. This is not the correct fix for anything. Anything with a badge number is unusable. Edit: Also added 48px for comparison and icon of Telegram with badge. Images are upscaled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21445.
This solves an issue where icons that are larger than the preferred size are not being rendered correctly. This issue surfaced as a side-effect of gfx's change from using the deprecated AppIndicator to now using KdeStatusNotifierItem over dbus.
More info: #21904 (comment)
Description of Change
If the icon is too large for the tray, tries to resize it to the correct size.
@codebytere
Checklist
npm testpassesRelease Notes
Notes: Fixed Linux desktop tray icon size regression introduced in the 8.0 betas.