examples: always start clean and update running instructions. #2045
+343
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Examples |
|
Wouldn't it be better to run each example in an independent Docker Compose namespace? So each will gets its own containers for Electric and the database, independent of the others. While the solution proposed in this PR solves the specific problem of starting in a clean state, it introduces other issues, such as inability to pause and resume the same example at a later time easily. |
|
The problem occurs when re-running the same example as much as across examples. I’d rather have the example work without weird stale data than support persistent data across restarts. Bear in mind it does print what’s happening to stdout. Is there a solution that can support the best of both worlds? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been working with the examples quite a lot and I've commonly experienced stale database and disk state from running
docker compose upin the foreground followed byctl+cto stop and also from forgetting to runpnpm backend:down.So ... as a systemic solution, I've updated the
example-backend:upscript in the root package.json to always runexample-backend:downfirst. This means that examples always start with a clean slate and no weird / stuck table and or disk state.I also then did a pass through the example READMEs, explaining this and re-formatting the instructions a touch.