feat: Add enhanced node repair configuration support #8512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements comprehensive enhanced node repair configuration
for EKS managed nodegroups with the following features:
- Support for percentage and count-based unhealthy node thresholds
- Configurable parallel repair limits (percentage and count)
- Advanced node repair config overrides for specific conditions
- Full CLI flag support for all new parameters
- Complete YAML configuration file support
- Backward compatibility with existing configurations
Key changes:
- Extended API types with new NodeRepairConfigOverride struct
- Added CLI flags for all new parameters
- Updated CloudFormation builder for AWS EKS integration
- Comprehensive unit and integration tests
- Updated documentation and examples
- Enhanced JSON schema validation
CLI Examples:
eksctl create cluster --enable-node-repair --node-repair-max-unhealthy-percentage=25
eksctl create nodegroup --enable-node-repair --node-repair-max-parallel-count=2
Config Examples:
nodeRepairConfig:
enabled: true
maxUnhealthyNodeThresholdPercentage: 20
maxParallelNodesRepairedCount: 2
nodeRepairConfigOverrides:
- nodeMonitoringCondition: NetworkNotReady
nodeUnhealthyReason: InterfaceNotUp
repairAction: Restart
minRepairWaitTimeMins: 15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR extends the existing node repair configuration in eksctl to support the full range of AWS EKS node repair parameters. The current implementation only supports a boolean
enabledflag, but AWS EKS supports additional parameters for fine-grained control over node repair behavior including thresholds, parallel repair limits, and custom repair overrides, as defined in EKS doc: https://docs.aws.amazon.com/eks/latest/APIReference/API_NodeRepairConfig.htmlChecklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯