[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quit menu item keyEquivalent #103

Open
ShlomoCode opened this issue Jul 8, 2024 · 6 comments
Open

quit menu item keyEquivalent #103

ShlomoCode opened this issue Jul 8, 2024 · 6 comments

Comments

@ShlomoCode
Copy link
Contributor

How is it possible to activate the keyboard shortcut? I can't do it, neither when the DockDoor settings are open nor when it's closed.
If this is indeed not possible, the indication of the shortcut keys must be displayed, to avoid confusion.

@ejbills
Copy link
Owner
ejbills commented Jul 9, 2024

It works for me when I don't have CMD set for the window switcher. I'm not sure how we can disable that built-in quit shortcut. I think we should just remove it, if possible.

@ShlomoCode
Copy link
Contributor Author

It's a macOS shortcut that should be valid in every application, I don't think it's worth removing. We just need to find a way not to display it in the menu bar but only when not in the settings window.
It is defined here

@ShlomoCode
Copy link
Contributor Author

Apple Human Interface Guidelines:

In general, don’t repurpose standard keyboard shortcuts for custom actions. People can get confused when the shortcuts they know work differently in your app or game. Only consider redefining a standard shortcut if its action doesn’t make sense in your experience. For example, if your app doesn’t support text editing, it doesn’t need a text-styling command like Italic, so you might repurpose Command–I for an action that has more relevance, like Get Info.

People expect each of the following standard keyboard shortcuts to perform the action listed in the table below.

...

Command-Q Quit the app.

@ShlomoCode
Copy link
Contributor Author

Ok, I see that when focused on the window, the keyboard shortcut doesn't work. So you just need to remove the keyEquivalent from the menu bar item, and instead add a keyEquivalent for the settings window.

@ShlomoCode
Copy link
Contributor Author

Maybe we would also like to add a "quit" button in the corner of the settings window?

ShlomoCode added a commit to ShlomoCode/DockDoor that referenced this issue Jul 9, 2024
ShlomoCode added a commit to ShlomoCode/DockDoor that referenced this issue Jul 9, 2024
@ShlomoCode
Copy link
Contributor Author

sindresorhus/Settings#40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants