Set the "Dictionary" preference as part of the Oomph setup#847
Set the "Dictionary" preference as part of the Oomph setup#847ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom
Conversation
setups/WindowBuilder.setup
Outdated
| <setupTask | ||
| xsi:type="setup:PreferenceTask" | ||
| key="/instance/org.eclipse.jdt.ui/spelling_user_dictionary" | ||
| value="${workspace.location|uri}/git/windowbuilder/org.eclipse.wb.core/dictionary.txt"/> |
There was a problem hiding this comment.
I don’t think you should assume a relationship between the workspace location and the clone location. Is the value supposed to be a uri?
There was a problem hiding this comment.
Use the clone location
windowbuilder/setups/WindowBuilder.setup
Line 142 in 0f89c11
You can use |uri with that if the path should be converted to a uri.
There was a problem hiding this comment.
Using the clone location makes it look a lot cleaner. Thanks!
setups/WindowBuilder.setup
Outdated
| <setupTask | ||
| xsi:type="setup:PreferenceTask" | ||
| key="/instance/org.eclipse.jdt.ui/spelling_user_dictionary" | ||
| value="${workspace.location|uri}/git/windowbuilder/org.eclipse.wb.core/dictionary.txt"/> |
There was a problem hiding this comment.
Use the clone location
windowbuilder/setups/WindowBuilder.setup
Line 142 in 0f89c11
You can use |uri with that if the path should be converted to a uri.
|
FYI,, not that it really matters so much, but if you use |
The dictionary for spell-checking is located in org.eclipse.wb.core. When the workspace is created by the Oomph installer, this file should be used to avoid warnings caused by unknown technical terms.
I suppose it's always good practice to avoid the chance of weird path-delimiter shenanigans. Thank you for your feedback! |
|
It looks perfect now. 👍 |
The dictionary for spell-checking is located in org.eclipse.wb.core. When the workspace is created by the Oomph installer, this file should be used to avoid warnings caused by unknown technical terms.