Consume JGoodies bundles from Orbit instead of using embedded jars#738
Merged
ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom Apr 3, 2024
Merged
Conversation
Contributor
Author
|
The license check is failing because of the same reason as in the Orbit repository: https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/14174 |
Contributor
|
Yes of course. The issues for the version with the qualifier are open because dash can’t map them automatically to maven source. Hopefully Rahul will close them tomorrow. For Orbit the build is parameterized whether to fail if dash finds/creates issues so that I’m not blocked from providing updates. |
Contributor
Author
|
Thankfully there is no rush. The main focus was to check whether the new bundles work and that I was able to achieve. 😄 |
Contributor
|
I know patience is a virtue. 😇 But in that regard I’m not virtuous. 😮 |
This removes the "org.eclipse.wb.swing.FormLayout.lib", which was used to wrap the plain jars "com.jgoodies-common" and "com.jgoodies-forms". Instead the bundles from Eclipse Orbit are used. Note that this also updates JGoodies Common to 1.8.1 and JGoodies Forms to 1.9.0, which are the last releases which are open source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the "org.eclipse.wb.swing.FormLayout.lib", which was used to wrap the plain jars "com.jgoodies-common" and "com.jgoodies-forms". Instead the bundles from Eclipse Orbit are used.
Note that this also updates JGoodies Common to 1.8.1 and JGoodies Forms to 1.9.0, which are the last releases which are open source.