Use absolute coordinates for start and end location while dragging#699
Merged
ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom Jan 27, 2024
Merged
Conversation
When dragging the cursor (e.g. to resize a figure), the corresponding tool would use the absolute coordinate of the cursor as start point, and the relative coordinate as end point when determining whether dragging should be enabled. This fails once the user scrolled slightly to the right/down. To fix this, simply replace the call to getCurrentInput().getMouseLocation() with getLocation(), which returns the ABSOLUTE mouse location. Resolves eclipse-windowbuilder#697
Contributor
Author
|
Added two test cases to check for horizontal/vertical scrolling to hopefully detect any potential regressions from here on out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When dragging the cursor (e.g. to resize a figure), the corresponding tool would use the absolute coordinate of the cursor as start point, and the relative coordinate as end point when determining whether dragging should be enabled.
This fails once the user scrolled slightly to the right/down. To fix this, simply replace the call to getCurrentInput().getMouseLocation() with getLocation(), which returns the ABSOLUTE mouse location.
Resolves #697