Initial batch for migration from Digester3 to JAXB#684
Merged
ptziegler merged 4 commits intoeclipse-windowbuilder:masterfrom Jan 13, 2024
Merged
Conversation
Part of the migration from Digester3 to JAXB. See eclipse-windowbuilder#638
The order is expected to be of type string. Note that because the order is an optional parameter, we have to wrap the setter invocation via acceptSafe. See eclipse-windowbuilder#638
The creation description is expected to be a string. Note that both the description and source are optional, hence why the setter invocation has to be wrapped via acceptSafe(). See eclipse-windowbuilder#638
It is important to note that the noInherit property needs to be checked before the new morph targets are added, to ensure that any parent targets are cleared before the targets of the current class are added. See eclipse-windowbuilder#638
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the complexity and required amount of change, each component is going to be migrated by a separate commit (as much as possible).
This is the first set of changes, consisting of the component toolkit, model, order creations and morphing targets.
#638