Remove usage of Guava Collections in WindowBuilder Core #270#658
Merged
ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom Dec 12, 2023
Merged
Conversation
…wbuilder#270 In almost all cases, the call of Lists.newArrayList() can be simply replaced with new ArrayList<>(). Occasionally, we use Arrays.asList() to create lists from arrays. But care has to be taken here, because those lists are read-only. If values are written to them afterwards, the constructed list is passed as an argument to an ArrayList. Note that we use Arrays.asList() instead of List.of(), as latter doesn't allow null elements. The MapMaker class which is used to create maps with weak keys/values are replaced by the ReferenceMap. The Multimap class is replaced by the MultiValueMap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In almost all cases, the call of Lists.newArrayList() can be simply replaced with new ArrayList<>().
Occasionally, we use Arrays.asList() to create lists from arrays. But care has to be taken here, because those lists are read-only. If values are written to them afterwards, the constructed list is passed as an argument to an ArrayList.
Note that we use Arrays.asList() instead of List.of(), as latter doesn't allow null elements.
The MapMaker class which is used to create maps with weak keys/values are replaced by the ReferenceMap.
The Multimap class is replaced by the MultiValueMap.