[GTK] Cleanup SWT snapshot mechanism on Linux systems#610
Merged
ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom Nov 14, 2023
Merged
Conversation
4a6db82 to
f7c70a7
Compare
Contributor
Author
f7c70a7 to
869c9a3
Compare
869c9a3 to
1431a2e
Compare
e7e1d4e to
48021cd
Compare
337ae35 to
f01d3b0
Compare
Contributor
Author
|
Finally got around to setting up an isolated Wayland test environment and unsurprisingly, this change would re-introduce the segmentation fault if one doesn't use X11 😞 After a lot of trial & error, I think the solution is to clip the widget bounds with its visible area, something that I already did on a Java level and now moved to the C level instead. |
…uilder#609 This change consists of the following part: - The unused methods have been removed from the native C code. They were still called by the 32bit implementation. But given that this mode is no longer supported by SWT, there is no point in keeping it. - The snapshot mechanism exclusively uses the native implementation (how it used to be). This should hopefully avoid issues where a snapshot is taken before the widget has been rendered. - We no longer attempt to capture the decorations. Those are part of the window manager and not the shell itself. On X11, it is still possible (yet unreliable) but on Wayland it seems to be prohibited to access anything outside the widget. Doing so also causes several issues where the figures are cut off or offset by the insets of the window. Should resolve eclipse-windowbuilder#609
f01d3b0 to
1b75dd7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change consists of the following part:
The unused methods have been removed from the native C code. They were still called by the 32bit implementation. But given that this mode is no longer supported by SWT, there is no point in keeping it.
The snapshot mechanism exclusively uses the native implementation (how it used to be). This should hopefully avoid issues where a snapshot is taken before the widget has been rendered.
We no longer attempt to capture the decorations. Those are part of the window manager and not the shell itself. On X11, it is still possible (yet unreliable) but on Wayland it seems to be prohibited to access anything outside the widget.
Doing so also causes several issues where the figures are cut off or offset by the insets of the window.