8000 Consider the correct font when calculating the palette entry bounds by ptziegler · Pull Request #607 · eclipse-windowbuilder/windowbuilder · GitHub
[go: up one dir, main page]

Skip to content

Consider the correct font when calculating the palette entry bounds#607

Merged
ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom
ptziegler:issue605-palette-settings
Oct 23, 2023
Merged

Consider the correct font when calculating the palette entry bounds#607
ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom
ptziegler:issue605-palette-settings

Conversation

@ptziegler
Copy link
Contributor

The width and height of the palette entries (entry/components) is calculated using the font of the palette composite. Given that the user can set larger fonts for the entries, this may then end up in a situation where the text is larger than the figure, meaning the edges of the text are cut off.
This is fixed by using the correct font, in order to calculate the correct bounds of the figure using the Draw2D FigureUtilities class.

#605

The width and height of the palette entries (entry/components) is
calculated using the font of the palette composite.
Given that the user can set larger fonts for the entries, this may then
end up in a situation where the text is larger than the figure, meaning
the edges of the text are cut off.
This is fixed by using the correct font, in order to calculate the
correct bounds of the figure using the Draw2D FigureUtilities class.
@ptziegler ptziegler added this to the 1.14.0 milestone Oct 22, 2023
@ptziegler ptziegler linked an issue Oct 22, 2023 that may be closed by this pull request
@github-actions
Copy link
github-actions bot commented Oct 22, 2023

Unit Test Results

         4 files           4 suites   2h 6m 26s ⏱️
  7 650 tests   7 447 ✔️ 203 💤 0
30 600 runs  29 788 ✔️ 812 💤 0

Results for commit 86e0fb3.

♻️ This comment has been updated with latest results.

@ptziegler ptziegler merged commit af553cf into eclipse-windowbuilder:master Oct 23, 2023
@ptziegler ptziegler deleted the issue605-palette-settings branch October 23, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Palette settings & dialog is not user friendly

1 participant

0