Replace WB (Compound)Command classes with downstream GEF implementation#606
Merged
ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom Oct 22, 2023
Merged
Conversation
Contributor
Author
|
Note that 95% of this change just consists of shuffling the imports around... Both our commands and the GEF commands are effectively identical. |
6f66cac to
c7366e8
Compare
c7366e8 to
2840c1a
Compare
Those classes are almost identical, with the only difference being that execute() doesn't throw an exception. Given that we don't rely on this functionality, it's effectively a drop-in replacement. Part of the ongoing process to synchronize our graphical editor with GEF.
2840c1a to
ae2ced2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those classes are almost identical, with the only difference being that execute() doesn't throw an exception. Given that we don't rely on this functionality, it's effectively a drop-in replacement.
Part of the ongoing process to synchronize our graphical editor with GEF.