Fix: Improper use of FontDescriptor to create bold fonts#577
Merged
ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom Sep 22, 2023
Merged
Conversation
We use the original font to create its bold variant. However, we never actually dispose this new instance, resulting in WidgetIsDisposed exceptions. The lifetime of those new fonts are now bound to its closest widget. Amends e3f2512
9ec3c49 to
e958e42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use the original font to create its bold variant. However, we never actually dispose this new instance, resulting in WidgetIsDisposed exceptions. The lifetime of those new fonts are now bound to its closest widget.
Amends e3f2512