8000 Explicitly discard created ICompilationUnits #1344 by ptziegler · Pull Request #1358 · eclipse-windowbuilder/windowbuilder · GitHub
[go: up one dir, main page]

Skip to content

Explicitly discard created ICompilationUnits #1344#1358

Merged
ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom
ptziegler:issue1344
Jan 24, 2026
Merged

Explicitly discard created ICompilationUnits #1344#1358
ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom
ptziegler:issue1344

Conversation

@ptziegler
Copy link
Contributor

Deleting a file is not guaranteed to remove the associated compilation unit from the JDT cache. If this CU remains a working copy, the content of this CU can't be changed, thus causing the tests to be executed on the snippet of the previous test.

To avoid this, we have to keep track of the created CUs and explicitly call "discardWorkingCopy()".

Contributes to
#1344

@ptziegler ptziegler added this to the 1.23.0 milestone Jan 24, 2026
@github-actions
Copy link
github-actions bot commented Jan 24, 2026

Test Results

 2 720 files  + 7   2 720 suites  +7   11h 0m 13s ⏱️ + 17m 16s
 7 004 tests ± 0   6 946 ✅ + 1   58 💤 ±0  0 ❌ ±0 
28 016 runs  +36  27 774 ✅ +37  242 💤 ±0  0 ❌ ±0 

Results for commit 71424ce. ± Comparison against base commit 56179dd.

♻️ This comment has been updated with latest results.

Deleting a file is not guaranteed to remove the associated compilation
unit from the JDT cache. If this CU remains a working copy, the content
of this CU can't be changed, thus causing the tests to be executed on
the snippet of the previous test.

To avoid this, we also have to call "discardWorkingCopy()".

Contributes to
eclipse-windowbuilder#1344
@ptziegler ptziegler merged commit 7ac46a4 into eclipse-windowbuilder:master Jan 24, 2026
8 checks passed
@ptziegler ptziegler deleted the issue1344 branch January 24, 2026 23:05
Sign up for free to join this conversation on GitHub. Already have an acc 5F5B ount? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0