8000 Remove "for_test" methods in PropertyTable by ptziegler · Pull Request #1320 · eclipse-windowbuilder/windowbuilder · GitHub
[go: up one dir, main page]

Skip to content

Remove "for_test" methods in PropertyTable#1320

Merged
ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom
ptziegler:remove-for-test-methods
Dec 16, 2025
Merged

Remove "for_test" methods in PropertyTable#1320
ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom
ptziegler:remove-for-test-methods

Conversation

@ptziegler
Copy link
Contributor

Those methods should be defined in the test bundle and not in the actual class!

@ptziegler ptziegler added this to the 1.23.0 milestone Dec 15, 2025
@github-actions
Copy link
github-actions bot commented Dec 15, 2025

Test Results

 2 720 files  ±0   2 720 suites  ±0   10h 46m 29s ⏱️ - 5m 0s
 7 004 tests ±0   6 946 ✅ ±0   58 💤 ±0  0 ❌ ±0 
28 016 runs  ±0  27 784 ✅ ±0  232 💤 ±0  0 ❌ ±0 

Results for commit cac4bb5. ± Comparison against base commit 3bdfd91.

♻️ This comment has been updated with latest results.

Those methods should be defined in the test bundle and not in the actual
class!
@ptziegler ptziegler force-pushed the remove-for-test-methods branch from b964794 to cac4bb5 Compare December 15, 2025 22:38
@ptziegler ptziegler merged commit e0432cc into eclipse-windowbuilder:master Dec 16, 2025
8 checks passed
@ptziegler ptziegler deleted the remove-for-test-methods branch December 16, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0