Store generated Java code for BorderField in a local variable#1262
Merged
ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom Oct 11, 2025
Merged
Conversation
Rather than calculating the 8000 source code whenever getSource() is called, it should be calculated when the internal BorderDialog is closed or when the border field is updated. This avoids timing issues where the border field hasn't been updated by the time the method is called.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.T
319E
his suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than calculating the source code whenever getSource() is called, it should be calculated when the internal BorderDialog is closed or when the border field is updated. This avoids timing issues where the border field hasn't been updated by the time the method is called.