Avoid creating a static shell for the BorderDialog#1260
Merged
ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom Oct 9, 2025
Merged
Avoid creating a static shell for the BorderDialog#1260ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom
ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom
Conversation
When the BorderDialog is opened for the first time, an invisible Shell is created, which is required for the source code generation. This Shell is never disposed. This invisible shell is now created as a child of the dialog.
Test Results 2 713 files 2 713 suites 9h 50m 33s ⏱️ For more details on these errors, see this check. Results for commit 133f7db. |
Contributor
Author
|
Test failure on Windows is unrelated. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the BorderDialog is opened for the first time, an invisible Shell is created, which is required for the source code generation. This Shell is never disposed. This invisible shell is now created as a child of the dialog.