Properly initialize fonts in FontPropertyEditorTest#1233
Merged
ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom Sep 17, 2025
Merged
Properly initialize fonts in FontPropertyEditorTest#1233ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom
ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom
Conversation
The test currently depends on the default font that is set by Swing. This font might be changed at any point by a different test, leading to failures that are difficult to track down. To make the test more stable, explicitly set the expected font at the start of the test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test currently depends on the default font that is set by Swing. This font might be changed at any point by a different test, leading to failures that are difficult to track down.
To make the test more stable, explicitly set the expected font at the start of the test.