Properly reset the EmbeddedSwingComposite when disposed#1231
Merged
ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom Sep 17, 2025
Merged
Conversation
be51701 to
57260a8
Compare
This restores the UIDefaults for the fonts when the widget is disposed. Otherwise changes to e.g. the LookAndFeel fonts would be preserved, even when the LookAndFeel dialog has been closed. Furthermore, disposing the Swing Frame is now done via a DisposeEvent. The dispose() method is not called recursively, so there is no guarantee that it is actually disposed.
57260a8 to
4378ec5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This restores the UIDefaults for the fonts when the widget is disposed. Otherwise changes to e.g. the LookAndFeel fonts would be preserved, even when the LookAndFeel dialog has been closed.
Furthermore, disposing the Swing Frame is now done via a DisposeEvent. The dispose() method is not called recursively, so there is no guarantee that it is actually disposed.