Encapsulate the Swing SpinnerModel using an ObservableValue#1227
Merged
ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom Sep 17, 2025
Merged
Conversation
Test Results 2 720 files 2 720 suites 9h 58m 5s ⏱️ Results for commit 325d331. ♻️ This comment has been updated with latest results. |
79f6f0c to
505b854
Compare
The SpinnerModel shown in the SpinnerModelDialog is currently updated in the SWT UI thread. On MacOS, this may lead to a deadlock, in case the SWT UI thread is waiting for the AWT event dispatch thread. Access to this model is now guarded by an ObservableValue, which requires proper synchronization. The dialog has been restructured to make sure modifications to this value are done exclusively in the event dispatch thread and that the dialog is only updated in the SWT UI thread. May close eclipse-windowbuilder#1204
505b854 to
325d331
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SpinnerModel shown in the SpinnerModelDialog is currently updated in the SWT UI thread. On MacOS, this may lead to a deadlock, in case the SWT UI thread is waiting for the AWT event dispatch thread.
Access to this model is now guarded by an ObservableValue, which requires proper synchronization. The dialog has been restructured to make sure modifications to this value are done exclusively in the event dispatch thread and that the dialog is only updated in the SWT UI thread.
May close
#1204