Encapsulate the Swing LookAndFeel using an ObservableValue#1224
Merged
ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom Sep 14, 2025
Merged
Encapsulate the Swing LookAndFeel using an ObservableValue#1224ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom
ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom
Conversation
Access to the Swing objects must be done from the AWT event dispatcher thread (aka the Swing UI thread). Rather than explicitly checking whether any method is called from this thread via e.g. the EventQueue, we can take advantage of the "Realm" concept provided by the Eclipse. The LookAndFeel is stored within an ObservableValue. The realm of this value is the Swing UI thread. Modifying this value from any other thread is guaranteed to throw an exception.
Contributor
Author
|
Using the Observable API seems to be the most promising approach, also for the other Swing objects such as Borders, TableModels and SpinnerModels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Access to the Swing objects must be done from the AWT event dispatcher thread (aka the Swing UI thread). Rather than explicitly checking whether any method is called from this thread via e.g. the EventQueue, we can take advantage of the "Realm" concept provided by the Eclipse.
The LookAndFeel is stored within an ObservableValue. The realm of this value is the Swing UI thread. Modifying this value from any other thread is guaranteed to throw an exception.