Ignore methods that are guaranteed to be inaccessible#1056
Merged
ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom May 2, 2025
Merged
Ignore methods that are guaranteed to be inaccessible#1056ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom
ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom
Conversation
The getMethods() should skip all methods that can't be made accessible in order edge-cases where methods are overridden by private subclasses and would thus hide the (possibly) public declaration in its parent class. Furthermore, the invokeMethod() should also check whether the method can be invoked and fail early. Contributes to eclipse-windowbuilder#1027
8670204 to
37258bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The getMethods() should skip all methods that can't be made accessible in order edge-cases where methods are overridden by private subclasses and would thus hide the (possibly) public declaration in its parent class.
Furthermore, the invokeMethod() should also check whether the method can be invoked and fail early.
Contributes to
#1027