Partially revert fix for Bug 502397#1054
Merged
ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom Apr 30, 2025
Merged
Partially revert fix for Bug 502397#1054ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom
ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom
Conversation
The fix accidentally removed a check that would prevent the key to be changed to an invalid value. Even with this check added back, the user can still use the original translation as key. See https://bugs.eclipse.org/bugs/show_bug.cgi?id=502397 > Bug 502397 - Provide alternative name generation for NLS keys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix accidentally removed a check that would prevent the key to be changed to an invalid value. Even with this check added back, the user can still use the original translation as key.
See https://bugs.eclipse.org/bugs/show_bug.cgi?id=502397