8000 Harmonize use of Windows and Linux line-breaks across files by ptziegler · Pull Request #1031 · eclipse-windowbuilder/windowbuilder · GitHub
[go: up one dir, main page]

Skip to content

Harmonize use of Windows and Linux line-breaks across files#1031

Merged
ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom
ptziegler:harmonize-line-endings
Apr 17, 2025
Merged

Harmonize use of Windows and Linux line-breaks across files#1031
ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom
ptziegler:harmonize-line-endings

Conversation

@ptziegler
Copy link
Contributor

Within the source code, 3721 files use the Windows line-break (\r\n), while 117 files use the Linux line-break (\n). However, some files use both.

This PR replaces all occurrences of "\r\n" in Linux-encoded files with "\n" and all occurrences of "\n" in Windows-encoded files with "\r\n".

Within the source code, 3721 files use the Windows line-break (\r\n),
while 117 files use the Linux line-break (\n). However, some files use
both.

This PR replaces all occurrences of "\r\n" in Linux-encoded files with
"\n" and all occurrences of "\n" in Windows-encoded files with "\r\n".
@merks
Copy link
Contributor
merks commented Apr 17, 2025

It’s frustrating how this happens! Good for you to fix it.

@ptziegler
Copy link
Contributor Author

I only noticed this because the same thing is happening right now in #1024. Because I updated the license header on a Linux machine, the new header is using "\n", even though the other lines use "\r\n".

And I can't use the "Convert line delimiter" action from the Eclipse IDE, because it just blindly re-formats everything and I don't watch to touch the 117 Linux-encoded files for no good reason... What a pain 😦

@ptziegler ptziegler added this to the 1.20.0 milestone Apr 17, 2025
@ptziegler ptziegler merged commit e711dc5 into eclipse-windowbuilder:master Apr 17, 2025
6 checks passed
@ptziegler ptziegler deleted the harmonize-line-endings branch April 17, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0