Refactor class-loader hack for property cache#1030
Merged
ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom Apr 19, 2025
Merged
Refactor class-loader hack for property cache#1030ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom
ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom
Conversation
33cd0cd to
afd820d
Compare
The methods used to hack a custom map into the class-loader won't work anymore, unless the java.base/java.lang module is explicitly opened. The ClassLoaderLocalMap has instead been refactored into a normal map, which is bound to the lifecycle of the project class-loader. Contributes to: eclipse-windowbuilder#764
afd820d to
123a651
Compare
Contributor
Author
|
I ran the tests locally without any noticeable class-loader leak. So I think this is good as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The methods used to hack a custom map into the class-loader won't work anymore, unless the java.base/java.lang module is explicitly opened. The ClassLoaderLocalMap has instead been refactored into a normal map, which is bound to the lifecycle of the project class-loader.
Contributes to:
#764