Avoid jumping if property table is refreshed by a change#1006
Merged
ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom Mar 17, 2025
Merged
Conversation
If the table is refreshed due to editing a property, it may happen that the table is scrolled to the very top and thus hiding the selection. This is because the active property is set before the new input. Thus the selection is done on an outdated edit-part. Instead the input should be set before the selection. Furthermore, the input needs to be validated, to ensure that the bounds of the figures are correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the table is refreshed due to editing a property, it may happen that the table is scrolled to the very top and thus hiding the selection. This is because the active property is set before the new input. Thus the selection is done on an outdated edit-part.
Instead the input should be set before the selection. Furthermore, the input needs to be validated, to ensure that the bounds of the figures are correct.