Harmonize property selection with edit-part selection#1003
Merged
ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom Mar 17, 2025
Merged
Harmonize property selection with edit-part selection#1003ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom
ptziegler merged 1 commit intoeclipse-windowbuilder:masterfrom
Conversation
c002b57 to
52bbf9b
Compare
When a property is selected, this now also selects the corresponding edit part. Doing so allows us to check whether an edit part is selected by simply checking the getSelected() flag, rather than having to compare against the local variable of the property table. To do so, the setActivePropertyInfo(PropertyInfo) now delegates its call to select(EditPart), which not only updates the local variable but also notifies the underlying viewer about this change. This can then be utilized in the isActiveProperty() method of the PropertyFigure.
52bbf9b to
1507274
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a property is selected, this now also selects the corresponding edit part. Doing so allows us to check whether an edit part is selected by simply checking the getSelected() flag, rather than having to compare against the local variable of the property table.
To do so, the setActivePropertyInfo(PropertyInfo) now delegates its call to select(EditPart), which not only updates the local variable but also notifies the underlying viewer about this change. This can then be utilized in the isActiveProperty() method of the PropertyFigure.