Check ranges for Micro URI and add missing test coverage#97
Merged
stevenhartley merged 2 commits intomainfrom Apr 22, 2024
Merged
Check ranges for Micro URI and add missing test coverage#97stevenhartley merged 2 commits intomainfrom
stevenhartley merged 2 commits intomainfrom
Conversation
|
Thanks for taking this on! 🙂 I'm going to approach this as if you're actually addressing issue #94 as it's a superset of #76 Noticed a couple of things we still need to check:
Also some general feedback -- I think it'd be a little cleaner to separate the validation logic out from the serialization itself. For reference, here's the PR from (edited to add some references to the relevant code sections) |
|
@stevenhartley, @neelam-kushwah -- I left some feedback in this comment which was not addressed. Is the plan to make a follow-up PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#76