fix(api): properly encode URLs in RelatedCollectionLinkNormalizer #2909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmattmann
approved these changes
Aug 1, 2022
carlobeltrame
approved these changes
Aug 1, 2022
| @@ -103,8 +103,8 @@ public function testGetSinglePeriodIsAllowedForManager() { | |||
| '_links' => [ | |||
| 'camp' => ['href' => $this->getIriFor('camp1')], | |||
| 'materialItems' => ['href' => '/material_items?period=%2Fperiods%2F'.$period->getId()], // TODO: fix encoding with https://github.com/ecamp/ecamp3/issues/2289 | |||
There was a problem hiding this comment.
Is this solved now? Can this TODO be removed?
There was a problem hiding this comment.
Yes, thanks. Removed the comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2289
After symfony/symfony#45658 made it into the release of symfony 6.1, we can now properly encode query parameters in
RelatedCollectionLinkNormalizerAlso tested Frontend side. Everything still working.