Enable an update to handle returned state#10
Merged
eblis merged 1 commit intoeblis:masterfrom Feb 22, 2025
NBIX-Mark-Southern:patch_returns_state
Merged
Enable an update to handle returned state#10eblis merged 1 commit intoeblis:masterfrom NBIX-Mark-Southern:patch_returns_state
eblis merged 1 commit intoeblis:masterfrom
NBIX-Mark-Southern:patch_returns_state
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My Odata system returns state from an update (PATCH) call. It makes sense to update the entity object with this and not need to make a separate call (force_refresh=True). The logic is the same as for an insert (POST) call.
As an aside, it may make sense to separate the save method into insert and update calls as in order to make an update without first having to query for an entity before updating it. To achieve this, I had to set
Entity.__odata__.persisted = Truewhich seems too obsure for a general pattern.