Fix some pin definitions for Adafruit QT Py RP2040 #397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverse pin definitions for A0 through A3
earlephilhower
requested changes
Dec 30, 2021
There was a problem hiding this comment.
Thanks for the fix!
You bring up a good question for which I really don't have a good answer.
However, I'm thinking the best way to do this is to modify common to allow overrides w/a "well known" #define __PIN_A0 XXX
So common.h would be something like:
#ifdef __PIN_A0
const int A0 = __PIN_A0;
#else
const int A0 = (26u);
....
or
#ifndef __PIN_A0
#define __PIN_A0 (26u)
#endif
....
const int A0 = __PIN_A0;
...
And your patch would be
#define __PIN_A0 (29u)
....
#include "../generic/common.h"
Does that seem reasonable?
Allows for more consistency on overrides for A0-A3 on boards that require it
earlephilhower
approved these changes
Dec 30, 2021
|
I think that way of modifying common to create a bit of a "standardized" method of overriding A0-A3 is the best way to go about this as well, since it provides a way for future variants that might need them changed to go about that this way instead of everyone coming up with different solutions down the road. |
|
Tagging @ladyada for interest. |
|
awesome! |
schkovich
pushed a commit
to schkovich/arduino-pico
that referenced
this pull request
May 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects the pin definitions for pins A0, A1, A2, and A3 on the Adafruit QT Py RP2040.
On this board, the four pins above are reversed compared to what's defined in the common pin configuration. The current way this PR is fixing this is to just use preprocessor
#definein the board-specificvariants/adafruit_qtpy/pins_arduino.hto override thestatic constdeclarations fromvariants/generic/common.hof those four pins. This method appears to work fine and compiles without warnings while keeping the general board variant style alive.Another option for correcting this problem would be to copy all the pin definitions from
variants/generic/common.hinto the board's specific file with the required changes and just not include thatcommon.hin it, but that way doesn't fit the style of how other boards are defined, so is this method in the PR okay with you, or would you prefer it be done more like this other method?