10000 Update Mercure configuration in Caddyfile by 7-zete-7 · Pull Request #766 · dunglas/symfony-docker · GitHub
[go: up one dir, main page]
Skip to content

Update Mercure configuration in Caddyfile #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2025
Merged

Update Mercure configuration in Caddyfile #766

merged 1 commit into from
Mar 27, 2025

Conversation

7-zete-7
Copy link
Contributor

Due to dunglas/mercure#939 and the deprecation message, it makes sense to apply the Mercure configuration changes.

See:

@7-zete-7
Update Mercure configuration in Caddyfile
9cad901 
Due to dunglas/mercure#939 and the deprecation message, it makes sense to apply the edits to update the Mercure configuration.

See https://github.com/dunglas/mercure/blob/main/docs/UPGRADE.md#017
@7-zete-7
Copy link
Contributor Author

It might be more correct to replace it with the new configuration format

 {$SERVER_NAME:localhost} {
 	# ...
 	mercure {
+ 		# Transport to use (default to Bolt)
+		transport bolt {
+			path /data/mercure.db
+		}

However, this is already the default value. Backward compatibility (configuration via the environment variable MERCURE_TRANSPORT_URL) will also be broken.

@dunglas
Copy link
Owner
dunglas commented Mar 27, 2025

Simplifying the config is ok. MERCURE_TRANSPORT_URL BC is handled directly by Mercure.

@dunglas dunglas merged commit 46fa840 into dunglas:main Mar 27, 2025
2 checks passed
@maxhelias maxhelias mentioned this pull request Mar 27, 2025
Closed
@7-zete-7
Copy link
Contributor Author
7-zete-7 commented Mar 27, 2025 •
edited
Loading

I was too hasty with the default value. I found out that Mercure's default path option is ./bolt.db. To keep the value the same, the MERCURE_TRANSPORT_URL environment variable must be explicitly set.

See https://github.com/dunglas/mercure/blob/6e73d7278ceb43c7cfd941089fe7bf984617a515/bolt.go#L88-L90

@7-zete-7 7-zete-7 mentioned this pull request Mar 27, 2025
Merged
maxhelias pushed a commit that referenced this pull request Mar 27, 2025
@7-zete-7 @maxhelias
Add default value of the MERCURE_TRANSPORT_URL in Dockerfile
1b01814 
This should return the path that was changed in #766.
@7-zete-7 7-zete-7 deleted the patch-1 branch April 8, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas dunglas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@7-zete-7 @dunglas
0