minor symfony#25008 [Console] Remove remaining dead code (chalasr)

fabpot · fabpot · commit 94470169794f · 2017-11-18T09:40:15.000+02:00
This PR was merged into the 2.7 branch. Discussion ---------- [Console] Remove remaining dead code | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Since they are always re-thrown, no need to catch `\Error` instances at all. Commits ------- 3822c07 [Console] Remove remaining dead code
diff --git a/src/Symfony/Component/Console/Application.php b/src/Symfony/Component/Console/Application.php
@@ -113,11 +113,10 @@ public function run(InputInterface $input = null, OutputInterface $output = null
             $e = null;
             $exitCode = $this->doRun($input, $output);
         } catch (\Exception $e) {
-        } catch (\Throwable $e) {
         }
 
         if (null !== $e) {
-            if (!$this->catchExceptions || !$e instanceof \Exception) {
+            if (!$this->catchExceptions) {
                 throw $e;
             }
 

Original file line number	Diff line number	Diff line change
`@@ -113,11 +113,10 @@ public function run(InputInterface $input = null, OutputInterface $output = null`
`113`	`113`	`$e = null;`
`114`	`114`	`$exitCode = $this->doRun($input, $output);`
`115`	`115`	`} catch (\Exception $e) {`
`116`		`- } catch (\Throwable $e) {`
`117`	`116`	`}`
`118`	`117`
`119`	`118`	`if (null !== $e) {`
`120`		`- if (!$this->catchExceptions \|\| !$e instanceof \Exception) {`
	`119`	`+ if (!$this->catchExceptions) {`
`121`	`120`	`throw $e;`
`122`	`121`	`}`
`123`	`122`