Feature/david/refresh versions #1090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<
8000
batch-deferred-content class="d-inline-block" data-url="/duckduckgo/Android/commits/checks-statuses-rollups">
malmstein
commented
Feb 5, 2021
| @@ -134,92 +134,92 @@ ext { | |||
|
|
|||
|
|
|||
| dependencies { | |||
| implementation "androidx.legacy:legacy-support-v4:$legacySupport" | |||
| debugImplementation "com.squareup.leakcanary:leakcanary-android:$leakCanary" | |||
| implementation AndroidX.legacy.supportV4 | |||
There was a problem hiding this comment.
the plugin provides read-to-use organized dependency notations for some libraries, this is why this has changed
| implementation AndroidX.swipeRefreshLayout | ||
| implementation AndroidX.webkit | ||
| implementation Square.okHttp3.okHttp | ||
| implementation "com.squareup.okhttp3:okhttp-tls:_" |
There was a problem hiding this comment.
unfortunately, not all libraries have notations
# Conflicts: # app/build.gradle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/488551667048375/1199900494889724
Description:
We want to improve the way we update dependencies in the project. With that in mind, we want to introduce https://jmfayard.github.io/refreshVersions/
The difference now is that all the library versions are stored in one file
versions.properties, which the plugin uses to then indicate what version to use.Steps to test this PR:
versions.propertiesgradle refreshVersionsversions.propertiesInternal references:
Software Engineering Expectations
Technical Design Template