[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide support for continuous profiling #14972

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ywelsch
Copy link
Contributor
@ywelsch ywelsch commented Nov 25, 2024

DuckDB's profiler gives excellent insights into where time is being spent in a long-running query. It currently only exposes this information at the end of query execution, though. The PR here makes it possible to get profile information while the query is executing, providing a way to make this information externally visible during query execution (similar to query progress).

Copy link
Collaborator
@Mytherin Mytherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! LGTM - I wonder if we need the recursive_mutex, or if we can make due with a regular mutex for public members by e.g. adding Internal methods?

@ywelsch
Copy link
Contributor Author
ywelsch commented Nov 26, 2024

I wonder if we need the recursive_mutex, or if we can make due with a regular mutex for public members by e.g. adding Internal methods?

Thanks, I will investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants