E52F Swift test mocking enchancements by julianlocke · Pull Request #315 · dropbox/stone · GitHub
[go: up one dir, main page]
Skip to content

Swift test mocking enchancements#315

Merged
julianlocke merged 2 commits intoswifty-dropbox-betafrom
swift-test-mocking-enchancements
Dec 15, 2023
Merged

Swift test mocking enchancements#315
julianlocke merged 2 commits intoswifty-dropbox-betafrom
swift-test-mocking-enchancements

Conversation

@julianlocke
Copy link
Contributor
@julianlocke julianlocke commented Dec 15, 2023 •
edited
Loading

See dropbox/SwiftyDropbox#392 for generated code output.

Make route api objects conform to JSONRepresentable, and route namespace objects conform to DropboxTransportClientOwning.

Avoid stack overflows in description vars that fallback on themselves when serialization errors.

Checklist

General Contributing

  • Have you read the Code of Conduct and signed the CLA?

Is This a Code Change?

  • Non-code related change (markdown/git settings etc)
  • Code Change
  • Example/Test Code Change

Validation

  • Have you ran tox?
  • Do the tests pass?

@codecov
Copy link
codecov bot commented Dec 15, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (94fa542) 50.30% compared to head (f02b6de) 50.28%.
Report is 8 commits behind head on swifty-dropbox-beta.

Files Patch % Lines
stone/cli.py 0.00% 16 Missing ⚠️
stone/backends/swift_client.py 0.00% 1 Missing ⚠️
stone/frontend/ir_generator.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@                   Coverage Diff                   @@
##           swifty-dropbox-beta     #315      +/-   ##
=======================================================
- Coverage                50.30%   50.28%   -0.03%     
=======================================================
  Files                       37       37              
  Lines                     8740     8744       +4     
  Branches                  1881     1881              
=======================================================
  Hits                      4397     4397              
- Misses                    4026     4030       +4     
  Partials                   317      317
Flag Coverage Δ
unit 50.28% <5.26%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@julianlocke julianlocke requested a review from jaquish December 15, 2023 18:30
@julianlocke julianlocke mentioned this pull request Dec 15, 2023
Merged
jaquish
jaquish approved these changes Dec 15, 2023
View reviewed changes
Copy link
@jaquish jaquish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julianlocke julianlocke merged commit 3e08b02 into swifty-dropbox-beta Dec 15, 2023
@julianlocke julianlocke deleted the swift-test-mocking-enchancements branch December 15, 2023 22:35
julianlocke pushed a commit that referenced this pull request Aug 27, 2024
Swift test mocking enchancements (#315)
698cb31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaquish jaquish jaquish approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@julianlocke @jaquish
0