8000 feat(col): support column scope data struct by VicKun4937 · Pull Request #5542 · dream-num/univer · GitHub
[go: up one dir, main page]
Skip to content

feat(col): support column scope data struct #5542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 13 commits into
base: dev
Choose a base branch
from
Draft

feat(col): support column scope data struct #5542

wants to merge 13 commits into from

Conversation

VicKun4937
Copy link
Member
  • change the columnData to scopeColumn data
// from
 {
    [col:number]:ICoulmunData
 }
//to
[
  {start:number, end:number: data: ICoulmunData}
]

@VicKun4937 VicKun4937 marked this pull request as draft July 16, 2025 12:31
@github-actions GitHub Actions
Copy link
github-actions bot commented Jul 16, 2025 •
edited
Loading

View Deployment

📑 Demo (React@19) Demo (React@16) 📚 Storybook
🔗 Preview link 🔗 Preview link 🔗 Preview link

8000
@github-actions GitHub Actions
Copy link
github-actions bot commented Jul 16, 2025 •
edited
Loading

Playwright test results

passed  26 passed

Details

stats  26 tests across 12 suites
duration  6 minutes, 6 seconds
commit  ecb27a5
info  For more information, see full report

VicKun4937
VicKun4937 commented Jul 18, 2025
View reviewed changes
@codecov Codecov
Copy link
codecov bot commented Jul 22, 2025

Codecov Report

Attention: Patch coverage is 63.02895% with 166 lines in your changes missing coverage. Please review.

Project coverage is 33.04%. Comparing base (d9a9b58) to head (ecb27a5).
Report is 5 commits behind head on dev.

Files with missing lines Patch % Lines
packages/core/src/sheets/scope-column-manager.ts 74.58% 91 Missing ⚠️
packages/core/src/sheets/column-manager.ts 5.79% 65 Missing ⚠️
...der/src/components/sheets/sheet.render-skeleton.ts 0.00% 4 Missing ⚠️
packages/core/src/sheets/sheet-skeleton.ts 0.00% 3 Missing ⚠️
...c/engine/reference-object/base-reference-object.ts 0.00% 2 Missing ⚠️
...ngine-formula/src/services/current-data.service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #5542      +/-   ##
==========================================
+ Coverage   32.98%   33.04%   +0.06%     
==========================================
  Files        2751     2752       +1     
  Lines      143873   144293     +420     
  Branches    32057    32167     +110     
==========================================
+ Hits        47455    47687     +232     
- Misses      96418    96606     +188

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jikkai jikkai Awaiting requested review from jikkai jikkai is a code owner

@Jocs Jocs Awaiting requested review from Jocs Jocs is a code owner

@Dushusir Dushusir Awaiting requested review from Dushusir Dushusir is a code owner

@wpxp123456 wpxp123456 Awaiting requested review from wpxp123456 wpxp123456 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@VicKun4937
0